Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/str2bool updatee #2007

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Bugfix/str2bool updatee #2007

merged 2 commits into from
Oct 18, 2023

Conversation

sam-fakhreddine
Copy link
Contributor

Summary

This PR replaces the outdated str2bool package with a new package, str2bool3, that is optimized for compatibility with Python versions greater than 3.8.
Why This Is Needed

The str2bool package was last updated 7 years ago and doesn't support Python versions >3.8. This change ensures that our project remains up-to-date and compatible with modern Python versions.
What Changed
Added

Integrated the str2bool3 package into the project.

Changed

Updated all instances where the str2bool package was being used to now use str2bool3.

Fixed

Resolved compatibility issues related to using str2bool with Python >3.8.

Removed

Removed dependency on the outdated str2bool package.

@github-actions github-actions bot added bug Something isn't working changelog:patch Patch change resulting in a patch release poetry Update to Poetry configuration python Update to Python code labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2007 (14949c5) into master (5be6cf3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         247      247           
  Lines       15680    15680           
=======================================
  Hits        14141    14141           
  Misses       1539     1539           
Files Coverage Δ
runway/context/_runway.py 95.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be6cf3...14949c5. Read the comment docs.

@sam-fakhreddine sam-fakhreddine merged commit b70b130 into master Oct 18, 2023
29 of 30 checks passed
@ITProKyle ITProKyle deleted the bugfix/str2bool-updatee branch August 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:patch Patch change resulting in a patch release poetry Update to Poetry configuration python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant